[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/12] virtio: move ioeventfd_started flag to Vi
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 02/12] virtio: move ioeventfd_started flag to VirtioBusState |
Date: |
Thu, 29 Sep 2016 15:36:28 +0100 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Wed, Sep 21, 2016 at 03:18:49PM +0200, Paolo Bonzini wrote:
> This simplifies the code and removes the ioeventfd_started
> and ioeventfd_set_started callback. The only difference is
> in how virtio-ccw handles an error---it doesn't disable
> ioeventfd forever anymore. It was the only backend to do
> so, and if desired this behavior should be implemented in
> virtio-bus.c.
>
> Instead of ioeventfd_started, the ioeventfd_assign callback now
> determines whether the virtio bus supports host notifiers.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> hw/block/dataplane/virtio-blk.c | 2 +-
> hw/s390x/virtio-ccw.c | 21 ---------------------
> hw/s390x/virtio-ccw.h | 1 -
> hw/scsi/virtio-scsi-dataplane.c | 2 +-
> hw/virtio/vhost.c | 2 +-
> hw/virtio/virtio-bus.c | 14 ++++++--------
> hw/virtio/virtio-mmio.c | 18 ------------------
> hw/virtio/virtio-pci.c | 17 -----------------
> hw/virtio/virtio-pci.h | 1 -
> include/hw/virtio/virtio-bus.h | 17 +++++++----------
> 10 files changed, 16 insertions(+), 79 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop, Paolo Bonzini, 2016/09/21
- [Qemu-devel] [PATCH 01/12] virtio: move ioeventfd_disabled flag to VirtioBusState, Paolo Bonzini, 2016/09/21
- [Qemu-devel] [PATCH 04/12] virtio: introduce virtio_device_ioeventfd_enabled, Paolo Bonzini, 2016/09/21
- [Qemu-devel] [PATCH 02/12] virtio: move ioeventfd_started flag to VirtioBusState, Paolo Bonzini, 2016/09/21
- Re: [Qemu-devel] [PATCH 02/12] virtio: move ioeventfd_started flag to VirtioBusState,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 05/12] virtio-blk: always use dataplane path if ioeventfd is active, Paolo Bonzini, 2016/09/21
- [Qemu-devel] [PATCH 03/12] virtio: add start_ioeventfd and stop_ioeventfd to VirtioDeviceClass, Paolo Bonzini, 2016/09/21
- [Qemu-devel] [PATCH 07/12] Revert "virtio: Introduce virtio_add_queue_aio", Paolo Bonzini, 2016/09/21
- [Qemu-devel] [PATCH 06/12] virtio-scsi: always use dataplane path if ioeventfd is active, Paolo Bonzini, 2016/09/21
- [Qemu-devel] [PATCH 11/12] virtio: inline virtio_queue_set_host_notifier_fd_handler, Paolo Bonzini, 2016/09/21
- [Qemu-devel] [PATCH 10/12] virtio: do not export set_host_notifier_internal, Paolo Bonzini, 2016/09/21
- [Qemu-devel] [PATCH 09/12] virtio: remove ioeventfd_disabled altogether, Paolo Bonzini, 2016/09/21