[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v14 03/21] qapi: add trace events for visitor
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v14 03/21] qapi: add trace events for visitor |
Date: |
Fri, 30 Sep 2016 10:49:28 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 09/30/2016 09:45 AM, Daniel P. Berrange wrote:
> Allow tracing of the operation of visitors
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> Makefile.objs | 1 +
> qapi/qapi-visit-core.c | 27 +++++++++++++++++++++++++++
> qapi/trace-events | 33 +++++++++++++++++++++++++++++++++
> 3 files changed, 61 insertions(+)
> create mode 100644 qapi/trace-events
Reviewed-by: Eric Blake <address@hidden>
> +
> +visit_start_alternate(void *v, const char *name, void *obj, size_t size,
> bool promote_int) "v=%p name=%s obj=%p size=%zu promote_int=%d"
Unrelated to your patch, but should the trace engines be taught how to
honor line wrapping in the trace files?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v14 00/21] QAPI/QOM work for non-scalar object properties, Daniel P. Berrange, 2016/09/30
- [Qemu-devel] [PATCH v14 01/21] option: make parse_option_bool/number non-static, Daniel P. Berrange, 2016/09/30
- [Qemu-devel] [PATCH v14 03/21] qapi: add trace events for visitor, Daniel P. Berrange, 2016/09/30
- Re: [Qemu-devel] [PATCH v14 03/21] qapi: add trace events for visitor,
Eric Blake <=
- [Qemu-devel] [PATCH v14 02/21] qdict: implement a qdict_crumple method for un-flattening a dict, Daniel P. Berrange, 2016/09/30
- [Qemu-devel] [PATCH v14 04/21] qapi: rename QmpInputVisitor to QObjectInputVisitor, Daniel P. Berrange, 2016/09/30
- [Qemu-devel] [PATCH v14 06/21] qapi: don't pass two copies of TestInputVisitorData to tests, Daniel P. Berrange, 2016/09/30
- [Qemu-devel] [PATCH v14 08/21] qapi: allow QObjectInputVisitor to be created with QemuOpts, Daniel P. Berrange, 2016/09/30
- [Qemu-devel] [PATCH v14 05/21] qapi: rename QmpOutputVisitor to QObjectOutputVisitor, Daniel P. Berrange, 2016/09/30
- [Qemu-devel] [PATCH v14 07/21] qapi: permit scalar type conversions in QObjectInputVisitor, Daniel P. Berrange, 2016/09/30
- [Qemu-devel] [PATCH v14 09/21] qapi: permit auto-creating single element lists, Daniel P. Berrange, 2016/09/30