Re: [Qemu-devel] [QEMU PATCH v5 0/6] migration: ensure hotplug and migration work together

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [QEMU PATCH v5 0/6] migration: ensure hotplug and 
migration work together

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
d935e1f migration: spapr: migrate pending_events of spapr state
64aa229 migration: spapr: migrate ccs_list in spapr state
ecf2d6c migration: migrate QTAILQ
6f641b8 migration: extend VMStateInfo
803e704 migration: spapr_drc: defined VMStateDescription struct
08b0c64 migration: alternative way to set instance_id in SaveStateEntry

=== OUTPUT BEGIN ===
Checking PATCH 1/6: migration: alternative way to set instance_id in 
SaveStateEntry...
Checking PATCH 2/6: migration: spapr_drc: defined VMStateDescription struct...
ERROR: space required before the open parenthesis '('
#69: FILE: hw/ppc/spapr_drc.c:634:
+    switch(drc->type) {

total: 1 errors, 0 warnings, 135 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/6: migration: extend VMStateInfo...
Checking PATCH 4/6: migration: migrate QTAILQ...
ERROR: spaces required around that '+' (ctx:WxV)
#108: FILE: include/qemu/queue.h:467:
+            *((void **) ((char *) (head) +QTAILQ_LAST_OFFSET));                
\
                                          ^

ERROR: spaces required around that '+' (ctx:WxV)
#109: FILE: include/qemu/queue.h:468:
+        **((void ***)((char *) (head) +QTAILQ_LAST_OFFSET)) = (elm);           
\
                                       ^

total: 2 errors, 0 warnings, 184 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/6: migration: spapr: migrate ccs_list in spapr state...
ERROR: spaces required around that '*' (ctx:VxV)
#66: FILE: hw/ppc/spapr.c:1287:
+    .subsections = (const VMStateDescription*[]) {
                                             ^

total: 1 errors, 0 warnings, 46 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 6/6: migration: spapr: migrate pending_events of spapr state...
ERROR: code indent should never use tabs
#96: FILE: hw/ppc/spapr_events.c:234:
+^I^I^I^I int data_size)$

total: 1 errors, 0 warnings, 159 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden