[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 17/17] vfio/pci: Handle host oversight
From: |
Eric Auger |
Subject: |
[Qemu-devel] [PATCH v5 17/17] vfio/pci: Handle host oversight |
Date: |
Thu, 6 Oct 2016 16:07:38 +0000 |
In case the end-user calls qemu with -vfio-pci option without passing
either sysfsdev or host property value, the device is interpreted as
0000:00:00.0. Let's create a specific error message to guide the end-user.
Signed-off-by: Eric Auger <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
---
---
hw/vfio/pci.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 6d01324..fef436a 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -2520,6 +2520,13 @@ static void vfio_realize(PCIDevice *pdev, Error **errp)
int i, ret;
if (!vdev->vbasedev.sysfsdev) {
+ if (!(~vdev->host.domain || ~vdev->host.bus ||
+ ~vdev->host.slot || ~vdev->host.function)) {
+ error_setg(errp, "No provided host device");
+ error_append_hint(errp, "Use -vfio-pci,host=DDDD:BB:DD.F "
+ "or -vfio-pci,sysfsdev=PATH_TO_DEVICE\n");
+ return;
+ }
vdev->vbasedev.sysfsdev =
g_strdup_printf("/sys/bus/pci/devices/%04x:%02x:%02x.%01x",
vdev->host.domain, vdev->host.bus,
@@ -2828,6 +2835,10 @@ static void vfio_instance_init(Object *obj)
device_add_bootindex_property(obj, &vdev->bootindex,
"bootindex", NULL,
&pci_dev->qdev, NULL);
+ vdev->host.domain = ~0U;
+ vdev->host.bus = ~0U;
+ vdev->host.slot = ~0U;
+ vdev->host.function = ~0U;
}
static Property vfio_pci_dev_properties[] = {
--
1.9.1
- Re: [Qemu-devel] [PATCH v5 08/17] vfio: Pass an Error object to vfio_connect_container, (continued)
- [Qemu-devel] [PATCH v5 06/17] vfio/pci: Pass an error object to vfio_add_capabilities, Eric Auger, 2016/10/06
- [Qemu-devel] [PATCH v5 10/17] vfio: Pass an error object to vfio_get_device, Eric Auger, 2016/10/06
- [Qemu-devel] [PATCH v5 09/17] vfio: Pass an error object to vfio_get_group, Eric Auger, 2016/10/06
- [Qemu-devel] [PATCH v5 12/17] vfio/platform: fix a wrong returned value in vfio_populate_device, Eric Auger, 2016/10/06
- [Qemu-devel] [PATCH v5 11/17] vfio/platform: Pass an error object to vfio_populate_device, Eric Auger, 2016/10/06
- [Qemu-devel] [PATCH v5 14/17] vfio/pci: Conversion to realize, Eric Auger, 2016/10/06
- [Qemu-devel] [PATCH v5 13/17] vfio/platform: Pass an error object to vfio_base_device_init, Eric Auger, 2016/10/06
- [Qemu-devel] [PATCH v5 15/17] vfio/pci: Remove vfio_msix_early_setup returned value, Eric Auger, 2016/10/06
- [Qemu-devel] [PATCH v5 16/17] vfio/pci: Remove vfio_populate_device returned value, Eric Auger, 2016/10/06
- [Qemu-devel] [PATCH v5 17/17] vfio/pci: Handle host oversight,
Eric Auger <=
- Re: [Qemu-devel] [PATCH v5 00/17] Convert VFIO-PCI to realize, Markus Armbruster, 2016/10/07
- Re: [Qemu-devel] [PATCH v5 00/17] Convert VFIO-PCI to realize, no-reply, 2016/10/10