[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 3/8] intel_iommu: pass whole remapped address
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v4 3/8] intel_iommu: pass whole remapped addresses to apic |
Date: |
Sat, 8 Oct 2016 14:43:11 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, Oct 05, 2016 at 03:06:52PM +0200, Radim Krčmář wrote:
> The MMIO interface to APIC only allowed 8 bit addresses, which is not
> enough for 32 bit addresses from EIM remapping.
> Intel stored upper 24 bits in the high MSI address, so use the same
> technique. The technique is also used in KVM MSI interface.
> Other APICs are unlikely to handle those upper bits.
>
> Reviewed-by: Igor Mammedov <address@hidden>
> Signed-off-by: Radim Krčmář <address@hidden>
Again we are assuming MSIMessage as host endianess here.
If there is more spin for this one, maybe we can consider providing a
common function for:
apic_get_class()->send_msi(&msi);
And call it in the two places. But this one is good enough for me, so:
Reviewed-by: Peter Xu <address@hidden>
Thanks,
-- peterx
- Re: [Qemu-devel] [PATCH v4 2/8] apic: add send_msi() to APICCommonClass, (continued)
- Re: [Qemu-devel] [PATCH v4 3/8] intel_iommu: pass whole remapped addresses to apic,
Peter Xu <=
[Qemu-devel] [PATCH v4 4/8] intel_iommu: redo configuraton check in realize, Radim Krčmář, 2016/10/05
[Qemu-devel] [PATCH v4 6/8] intel_iommu: reject broken EIM, Radim Krčmář, 2016/10/05
[Qemu-devel] [PATCH v4 5/8] intel_iommu: add OnOffAuto intr_eim as "eim" property, Radim Krčmář, 2016/10/05
[Qemu-devel] [PATCH v4 7/8] intel_iommu: keep buggy EIM enabled in 2.7 machine type, Radim Krčmář, 2016/10/05