qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v1 0/2] Qemu: gdbstub: fix vCont and single-step


From: Claudio Imbrenda
Subject: [Qemu-devel] [PATCH v1 0/2] Qemu: gdbstub: fix vCont and single-step
Date: Mon, 10 Oct 2016 13:50:22 +0200

This small patchset fixes two bugs that affect the gdb stub.

The first one is the incorrect behaviour of the vCont command.
Previously, continuing or stepping a single thread (CPU) caused all
other CPUs to be started too, whereas the GDB specification clearly
states that without a default action all threads not explicitly
mentioned in the command should stay stopped.

So if the Qemu gdbstub receives a  vCont;c:1  packet, no other CPU
should be restarted except the first, and when a  vCont;s:1  is
received, the first CPU should be stepped without restarting the others.
With this patchset Qemu now behaves as expected.

See here for reference material about the packets: 
https://sourceware.org/gdb/onlinedocs/gdb/Packets.html

The second bug causes single-step mode not to work any longer, it was
introduced with commit e0eeb4a21a3ca4b296220ce4449d8acef9de9049 . This
bug causes all s (single-step) commands to behave like c (continue)
commands.

Claudio Imbrenda (2):
  gdbstub: Fix single-step
  gdbstub: Fix vCont behaviour

 gdbstub.c | 189 +++++++++++++++++++++++++++++++++++++++++++++++++-------------
 kvm-all.c |   1 +
 2 files changed, 151 insertions(+), 39 deletions(-)

-- 
1.9.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]