[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/24] qmp: teach qmp_dispatch() to take a pre-f
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 03/24] qmp: teach qmp_dispatch() to take a pre-filled QDict |
Date: |
Mon, 10 Oct 2016 15:20:55 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 10/10/2016 04:22 AM, Marc-André Lureau wrote:
> Give an optionnal qdict for the dispatch call to be used for the
s/optionnal/optional/
> reply. The qemu monitor has the request "id" pre-filled, simplifying a
> bit the code.
simplifying the code a bit
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> monitor.c | 26 +++++++++++---------------
> qapi/qmp-dispatch.c | 5 ++---
> qga/main.c | 2 +-
> tests/test-qmp-commands.c | 8 ++++----
> include/qapi/qmp/dispatch.h | 2 +-
> 5 files changed, 19 insertions(+), 24 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 00/24] qapi: add async command type, Marc-André Lureau, 2016/10/10
- [Qemu-devel] [PATCH 01/24] tests: start generic qemu-qmp tests, Marc-André Lureau, 2016/10/10
- [Qemu-devel] [PATCH 02/24] tests: change /0.15/* tests to /qmp/*, Marc-André Lureau, 2016/10/10
- [Qemu-devel] [PATCH 03/24] qmp: teach qmp_dispatch() to take a pre-filled QDict, Marc-André Lureau, 2016/10/10
- Re: [Qemu-devel] [PATCH 03/24] qmp: teach qmp_dispatch() to take a pre-filled QDict,
Eric Blake <=
- [Qemu-devel] [PATCH 04/24] qmp: use a return callback for the command reply, Marc-André Lureau, 2016/10/10
- [Qemu-devel] [PATCH 05/24] qmp: add QmpClient, Marc-André Lureau, 2016/10/10
- [Qemu-devel] [PATCH 06/24] qmp: add qmp_return_is_cancelled(), Marc-André Lureau, 2016/10/10
- [Qemu-devel] [PATCH 07/24] qmp: introduce async command type, Marc-André Lureau, 2016/10/10
- [Qemu-devel] [PATCH 08/24] qapi: ignore top-level 'id' field, Marc-André Lureau, 2016/10/10
- [Qemu-devel] [PATCH 10/24] qmp: check that async command have an 'id', Marc-André Lureau, 2016/10/10
- [Qemu-devel] [PATCH 09/24] qmp: take 'id' from request, Marc-André Lureau, 2016/10/10
- [Qemu-devel] [PATCH 11/24] scripts: learn 'async' qapi commands, Marc-André Lureau, 2016/10/10
- [Qemu-devel] [PATCH 12/24] tests: add dispatch async tests, Marc-André Lureau, 2016/10/10
- [Qemu-devel] [PATCH 13/24] monitor: add 'async' capability, Marc-André Lureau, 2016/10/10