[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/29] target-sparc: add UA2005 TTE bit #defines
From: |
Artyom Tarasenko |
Subject: |
Re: [Qemu-devel] [PATCH 03/29] target-sparc: add UA2005 TTE bit #defines |
Date: |
Mon, 10 Oct 2016 23:45:05 +0200 |
10 окт. 2016 г. 23:22 пользователь "Richard Henderson" <address@hidden>
написал:
>
> On 10/01/2016 05:05 AM, Artyom Tarasenko wrote:
>>
>> #define TTE_VALID_BIT (1ULL << 63)
>> #define TTE_NFO_BIT (1ULL << 60)
>> +#define TTE_NFO_BIT_UA2005 (1ULL << 62)
>> #define TTE_USED_BIT (1ULL << 41)
>> +#define TTE_USED_BIT_UA2005 (1ULL << 47)
>> #define TTE_LOCKED_BIT (1ULL << 6)
>> +#define TTE_LOCKED_BIT_UA2005 (1ULL << 61)
>> #define TTE_SIDEEFFECT_BIT (1ULL << 3)
>> +#define TTE_SIDEEFFECT_BIT_UA2005 (1ULL << 11)
>> #define TTE_PRIV_BIT (1ULL << 2)
>> +#define TTE_PRIV_BIT_UA2005 (1ULL << 8)
>> #define TTE_W_OK_BIT (1ULL << 1)
>> +#define TTE_W_OK_BIT_UA2005 (1ULL << 6)
>> #define TTE_GLOBAL_BIT (1ULL << 0)
>
>
> Hmm. Would it make more sense to reorg these as
>
> TTE_US1_*
> TTE_UA2005_*
>
> with some duplication for the bits that are shared?
> As is, it's pretty hard to tell which actually change...
All of them :-)
I'm not sure about renaming: the US1 format is still used in T1 on the read
access.
On the other hand, it's not used in T2. And then again we don't have the T2
emulation yet.
Artyom
[Qemu-devel] [PATCH 02/29] target-sparc: use explicit mmu register pointers, Artyom Tarasenko, 2016/10/01
[Qemu-devel] [PATCH 03/29] target-sparc: add UA2005 TTE bit #defines, Artyom Tarasenko, 2016/10/01
- Re: [Qemu-devel] [PATCH 03/29] target-sparc: add UA2005 TTE bit #defines, Richard Henderson, 2016/10/10
- Re: [Qemu-devel] [PATCH 03/29] target-sparc: add UA2005 TTE bit #defines,
Artyom Tarasenko <=
- Re: [Qemu-devel] [PATCH 03/29] target-sparc: add UA2005 TTE bit #defines, Richard Henderson, 2016/10/11
- Re: [Qemu-devel] [PATCH 03/29] target-sparc: add UA2005 TTE bit #defines, Artyom Tarasenko, 2016/10/11
- Re: [Qemu-devel] [PATCH 03/29] target-sparc: add UA2005 TTE bit #defines, Richard Henderson, 2016/10/11
- Re: [Qemu-devel] [PATCH 03/29] target-sparc: add UA2005 TTE bit #defines, Artyom Tarasenko, 2016/10/12
- Re: [Qemu-devel] [PATCH 03/29] target-sparc: add UA2005 TTE bit #defines, Richard Henderson, 2016/10/12
[Qemu-devel] [PATCH 04/29] target-sparc: add UltraSPARC T1 TLB #defines, Artyom Tarasenko, 2016/10/01
[Qemu-devel] [PATCH 06/29] target-sparc: simplify replace_tlb_entry by using TTE_PGSIZE, Artyom Tarasenko, 2016/10/01
[Qemu-devel] [PATCH 05/29] target-sparc: on UA2005 don't deliver Interrupt_level_n IRQs in hypervisor mode, Artyom Tarasenko, 2016/10/01