|
| From: | Richard Henderson |
| Subject: | Re: [Qemu-devel] [PATCH 21/29] target-sparc: allow 256M sized pages |
| Date: | Tue, 11 Oct 2016 09:07:56 -0500 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 10/01/2016 05:05 AM, Artyom Tarasenko wrote:
+ uint64_t mask = 1ULL + ~(8192ULL << 3 * TTE_PGSIZE(tlb->tte));
Not the first time it has appeared in this patch series, but I find the "1 + ~" idiom to be strange. Surely plain old "-" is clearer.
r~
| [Prev in Thread] | Current Thread | [Next in Thread] |