[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] block: Remove "options" indirection from blo
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v3] block: Remove "options" indirection from blockdev-add |
Date: |
Wed, 12 Oct 2016 17:41:46 +0800 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Tue, 10/11 15:27, Kevin Wolf wrote:
> Now that QAPI supports boxed types, we can have unions at the top level
> of a command, so let's put our real options directly there for
> blockdev-add instead of having a single "options" dict that contains the
> real arguments.
>
> blockdev-add is still experimental and we already made substantial
> changes to the API recently, so we're free to make changes like this
> one, too.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> Reviewed-by: Markus Armbruster <address@hidden>
Nice move!
Reviewed-by: Fam Zheng <address@hidden>