[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 4/4] target-arm: Comments added to identify cases
From: |
Thomas Hanson |
Subject: |
[Qemu-devel] [PATCH v3 4/4] target-arm: Comments added to identify cases in a switch |
Date: |
Wed, 12 Oct 2016 13:50:53 -0600 |
3 cases in a switch in disas_exc() require reference to the
ARM ARM spec in order to determine what case they're handling.
Signed-off-by: Thomas Hanson <address@hidden>
---
target-arm/translate-a64.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c
index b4a4b72..eb63e2f 100644
--- a/target-arm/translate-a64.c
+++ b/target-arm/translate-a64.c
@@ -1688,12 +1688,12 @@ static void disas_exc(DisasContext *s, uint32_t insn)
* instruction works properly.
*/
switch (op2_ll) {
- case 1:
+ case 1: /* SVC */
gen_ss_advance(s);
gen_exception_insn(s, 0, EXCP_SWI, syn_aa64_svc(imm16),
default_exception_el(s));
break;
- case 2:
+ case 2: /* HVC */
if (s->current_el == 0) {
unallocated_encoding(s);
break;
@@ -1706,7 +1706,7 @@ static void disas_exc(DisasContext *s, uint32_t insn)
gen_ss_advance(s);
gen_exception_insn(s, 0, EXCP_HVC, syn_aa64_hvc(imm16), 2);
break;
- case 3:
+ case 3: /* SMC */
if (s->current_el == 0) {
unallocated_encoding(s);
break;
--
1.9.1
- [Qemu-devel] [PATCH v3 0/4] target-arm: Handle tagged addresses when loading PC, Thomas Hanson, 2016/10/12
- [Qemu-devel] [PATCH v3 1/4] target-arm: Infrastucture changes to enable handling of tagged address loading into PC, Thomas Hanson, 2016/10/12
- [Qemu-devel] [PATCH v3 3/4] target-arm: Comments to mark location of pending work for 56 bit addresses, Thomas Hanson, 2016/10/12
- [Qemu-devel] [PATCH v3 4/4] target-arm: Comments added to identify cases in a switch,
Thomas Hanson <=
- [Qemu-devel] [PATCH v3 2/4] target-arm: Code changes to implement overwrite of tag field on PC load, Thomas Hanson, 2016/10/12
- Re: [Qemu-devel] [PATCH v3 0/4] target-arm: Handle tagged addresses when loading PC, Tom Hanson, 2016/10/13
- Re: [Qemu-devel] [PATCH v3 0/4] target-arm: Handle tagged addresses when loading PC, Peter Maydell, 2016/10/17