[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/15] xen: Fix coding style warnings
From: |
Emil Condrea |
Subject: |
Re: [Qemu-devel] [PATCH 02/15] xen: Fix coding style warnings |
Date: |
Thu, 13 Oct 2016 07:04:56 +0300 |
On Tue, Oct 11, 2016 at 5:20 PM, Anthony PERARD
<address@hidden> wrote:
> On Tue, Oct 04, 2016 at 09:43:31AM +0300, Emil Condrea wrote:
>> Fixes:
>> * WARNING: line over 80 characters
>>
>> Signed-off-by: Emil Condrea <address@hidden>
>> ---
>> hw/block/xen_disk.c | 3 ++-
>> hw/char/xen_console.c | 6 ++++--
>> hw/display/xenfb.c | 30 ++++++++++++++++++++----------
>> hw/net/xen_nic.c | 12 ++++++++----
>> hw/xen/xen_backend.c | 15 ++++++++++-----
>> include/hw/xen/xen_backend.h | 8 +++++---
>> 6 files changed, 49 insertions(+), 25 deletions(-)
>>
>> diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c
>> index 5aa350a..24edeb2 100644
>> --- a/hw/block/xen_disk.c
>> +++ b/hw/block/xen_disk.c
>> @@ -1068,7 +1068,8 @@ static int blk_connect(struct XenDevice *xendev)
>> blk_set_enable_write_cache(blkdev->blk, !writethrough);
>> } else {
>> /* setup via qemu cmdline -> already setup for us */
>> - xen_be_printf(&blkdev->xendev, 2, "get configured bdrv (cmdline
>> setup)\n");
>> + xen_be_printf(&blkdev->xendev, 2,
>> + "get configured bdrv (cmdline setup)\n");
>
> Arguments are usually aligned with the first one, so there is one
> missing space.
I guess this is displayed wrongly in the email client as in mine but the source
of the email contains this patch http://pastebin.com/Sbk23h6m, which shows that
this line is aligned to the first parameter.
>
>> blkdev->blk = blk_by_legacy_dinfo(blkdev->dinfo);
>> if (blk_is_read_only(blkdev->blk) && !readonly) {
>> xen_be_printf(&blkdev->xendev, 0, "Unexpected read-only drive");
>> diff --git a/hw/char/xen_console.c b/hw/char/xen_console.c
>> index 4e35c82..399bb5d 100644
>> --- a/hw/char/xen_console.c
>> +++ b/hw/char/xen_console.c
>> @@ -156,7 +156,8 @@ static void xencons_send(struct XenConsole *con)
>> if (len < 1) {
>> if (!con->backlog) {
>> con->backlog = 1;
>> - xen_be_printf(&con->xendev, 1, "backlog piling up, nobody
>> listening?\n");
>> + xen_be_printf(&con->xendev, 1,
>> + "backlog piling up, nobody listening?\n");
>
> same here and other places.
same as above
>
>> }
>> } else {
>> buffer_advance(&con->buffer, len);
>> @@ -247,7 +248,8 @@ static int con_initialise(struct XenDevice *xendev)
>> }
>> }
>>
>> - xen_be_printf(xendev, 1, "ring mfn %d, remote port %d, local port %d,
>> limit %zd\n",
>> + xen_be_printf(xendev, 1,
>> + "ring mfn %d, remote port %d, local port %d, limit %zd\n",
>> con->ring_ref,
>> con->xendev.remote_port,
>> con->xendev.local_port,
>> diff --git a/hw/xen/xen_backend.c b/hw/xen/xen_backend.c
>> index 545ee47..0aca6ae 100644
>> --- a/hw/xen/xen_backend.c
>> +++ b/hw/xen/xen_backend.c
>> @@ -205,7 +206,8 @@ int xenstore_read_fe_int(struct XenDevice *xendev, const
>> char *node, int *ival)
>> return xenstore_read_int(xendev->fe, node, ival);
>> }
>>
>> -int xenstore_read_fe_uint64(struct XenDevice *xendev, const char *node,
>> uint64_t *uval)
>> +int xenstore_read_fe_uint64(struct XenDevice *xendev, const char *node,
>> + uint64_t *uval)
>
> Same here, it would be better to align the second line with the first
> parameter.
This indeed should be fixed. I will send a new patch for it.
>
>> {
>> return xenstore_read_uint64(xendev->fe, node, uval);
>> }
>
> --
> Anthony PERARD
[Qemu-devel] [PATCH 06/15] xen: Move evtchn functions to xen_pvdev.c, Emil Condrea, 2016/10/04
[Qemu-devel] [PATCH 03/15] xen: Create a new file xen_pvdev.c, Emil Condrea, 2016/10/04
[Qemu-devel] [PATCH 05/15] xen: Move xenstore_update to xen_pvdev.c, Emil Condrea, 2016/10/04
[Qemu-devel] [PATCH 04/15] xen: Create a new file xen_frontend.c, Emil Condrea, 2016/10/04
[Qemu-devel] [PATCH 07/15] xen: Prepare xendev qtail to be shared with frontends, Emil Condrea, 2016/10/04
[Qemu-devel] [PATCH 08/15] xen: Move xenstore cleanup and mkdir functions, Emil Condrea, 2016/10/04