Re: [Qemu-devel] [PULL v2 19/20] trace: introduce a formal group name for trace events

[Paolo Bonzini]

On 12/10/2016 10:47, Stefan Hajnoczi wrote:
> +def make_group_name(filename):
> +    dirname = os.path.realpath(os.path.dirname(filename))
> +    basedir = os.path.join(os.path.dirname(__file__), os.pardir)
> +    basedir = os.path.realpath(os.path.abspath(basedir))
> +    dirname = dirname[len(basedir) + 1:]
> +
> +    if dirname == "":
> +        return "common"
> +    return re.sub(r"/|-", "_", dirname)
>  

The group is based on the build directory, so it includes the relative
path from srcdir to builddir.  My build directory is weird ("+build")
and breaks because of this.  Since the group is not really used for
anything yet, perhaps this patch could be reverted?

Paolo