[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 02/15] migration: Report values for comparisons
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PULL 02/15] migration: Report values for comparisons |
Date: |
Fri, 14 Oct 2016 17:28:10 +0200 |
From: "Dr. David Alan Gilbert" <address@hidden>
Report the values when a comparison fails; together with
the previous patch that prints the device and field names
this should give a good idea of why loading the migration failed.
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: John Snow <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>
---
migration/vmstate.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/migration/vmstate.c b/migration/vmstate.c
index 1d637b2..0bc9f35 100644
--- a/migration/vmstate.c
+++ b/migration/vmstate.c
@@ -557,6 +557,7 @@ static int get_int32_equal(QEMUFile *f, void *pv, size_t
size)
if (*v == v2) {
return 0;
}
+ error_report("%" PRIx32 " != %" PRIx32, *v, v2);
return -EINVAL;
}
@@ -580,6 +581,9 @@ static int get_int32_le(QEMUFile *f, void *pv, size_t size)
*cur = loaded;
return 0;
}
+ error_report("Invalid value %" PRId32
+ " expecting positive value <= %" PRId32,
+ loaded, *cur);
return -EINVAL;
}
@@ -685,6 +689,7 @@ static int get_uint32_equal(QEMUFile *f, void *pv, size_t
size)
if (*v == v2) {
return 0;
}
+ error_report("%" PRIx32 " != %" PRIx32, *v, v2);
return -EINVAL;
}
@@ -727,6 +732,7 @@ static int get_uint64_equal(QEMUFile *f, void *pv, size_t
size)
if (*v == v2) {
return 0;
}
+ error_report("%" PRIx64 " != %" PRIx64, *v, v2);
return -EINVAL;
}
@@ -748,6 +754,7 @@ static int get_uint8_equal(QEMUFile *f, void *pv, size_t
size)
if (*v == v2) {
return 0;
}
+ error_report("%x != %x", *v, v2);
return -EINVAL;
}
@@ -769,6 +776,7 @@ static int get_uint16_equal(QEMUFile *f, void *pv, size_t
size)
if (*v == v2) {
return 0;
}
+ error_report("%x != %x", *v, v2);
return -EINVAL;
}
--
2.7.4
- [Qemu-devel] [PULL 00/15] Migration v2, Juan Quintela, 2016/10/14
- [Qemu-devel] [PULL 01/15] migration: report an error giving the failed field, Juan Quintela, 2016/10/14
- [Qemu-devel] [PULL 02/15] migration: Report values for comparisons,
Juan Quintela <=
- [Qemu-devel] [PULL 03/15] migration/rdma: Pass qemu_file errors across link, Juan Quintela, 2016/10/14
- [Qemu-devel] [PULL 04/15] migration: Make failed migration load set file error, Juan Quintela, 2016/10/14
- [Qemu-devel] [PULL 08/15] migrate: Use boxed qapi for migrate-set-parameters, Juan Quintela, 2016/10/14
- [Qemu-devel] [PULL 07/15] migrate: Share common MigrationParameters struct, Juan Quintela, 2016/10/14
- [Qemu-devel] [PULL 09/15] migrate: Fix bounds check for migration parameters in migration.c, Juan Quintela, 2016/10/14
- [Qemu-devel] [PULL 05/15] migration/rdma: Don't flag an error when we've been told about one, Juan Quintela, 2016/10/14
- [Qemu-devel] [PULL 10/15] Postcopy vs xbzrle: Don't send xbzrle pages once in postcopy [for 2.8], Juan Quintela, 2016/10/14
- [Qemu-devel] [PULL 06/15] migrate: Fix cpu-throttle-increment regression in HMP, Juan Quintela, 2016/10/14
- [Qemu-devel] [PULL 11/15] RAMBlocks: Store page size, Juan Quintela, 2016/10/14
- [Qemu-devel] [PULL 13/15] migration: Fix seg with missing port, Juan Quintela, 2016/10/14