Re: [Qemu-devel] [PATCH v7 12/12] virtio-crypto: perfect algorithms chainning support

[Gonglei (Arei)]

> -----Original Message-----
> From: Stefan Hajnoczi [mailto:address@hidden
> Sent: Sunday, October 16, 2016 9:30 PM
> Subject: Re: [Qemu-devel] [PATCH v7 12/12] virtio-crypto: perfect algorithms
> chainning support
> 
> On Thu, Oct 13, 2016 at 03:12:06PM +0800, Gonglei wrote:
> > diff --git a/include/standard-headers/linux/virtio_crypto.h
> b/include/standard-headers/linux/virtio_crypto.h
> > index f2a059e..9ae02fb 100644
> > --- a/include/standard-headers/linux/virtio_crypto.h
> > +++ b/include/standard-headers/linux/virtio_crypto.h
> > @@ -326,7 +326,15 @@ struct virtio_crypto_mac_data_req {
> >  };
> >
> >  struct virtio_crypto_alg_chain_data_para {
> > -    struct virtio_crypto_cipher_para cipher;
> > +    __virtio32 iv_len;
> > +    /* Length of source data */
> > +    __virtio32 src_data_len;
> > +    /* Length of destination data */
> > +    __virtio32 dst_data_len;
> > +    /* Starting point for cipher processing in source data */
> > +    __virtio32 cipher_start_src_offset;
> > +    /* Length of the source data that the cipher will be computed on */
> > +    __virtio32 len_to_cipher;
> >      /* Starting point for hash processing in source data */
> >      __virtio32 hash_start_src_offset;
> >      /* Length of the source data that the hash will be computed on */
> > @@ -335,6 +343,7 @@ struct virtio_crypto_alg_chain_data_para {
> >      __virtio32 aad_len;
> >      /* Length of the hash result */
> >      __virtio32 hash_result_len;
> > +    __virtio32 reserved;
> >  };
> >
> >  struct virtio_crypto_alg_chain_data_req {
> 
> This is supposed to be an external header file from Linux.  QEMU patches
> normally don't change the file except to import an updated version.
> 
> Please import the final version once in the patch series and don't
> modify it.

You are right. Will fix it. :)


Regards,
-Gonglei