[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qapi: fix memory leak in bdrv_image_info_specif
From: |
Pino Toscano |
Subject: |
Re: [Qemu-devel] [PATCH] qapi: fix memory leak in bdrv_image_info_specific_dump |
Date: |
Tue, 18 Oct 2016 12:36:54 +0200 |
User-agent: |
KMail/5.3.1 (Linux/4.7.3-200.fc24.x86_64; KDE/5.26.0; x86_64; ; ) |
On Tuesday, 18 October 2016 11:44:26 CEST Kevin Wolf wrote:
> Am 18.10.2016 um 11:18 hat Pino Toscano geschrieben:
> > The 'obj' result of the visitor was not properly freed, like done in
> > other places doing a similar job.
> > ---
> > block/qapi.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/block/qapi.c b/block/qapi.c
> > index 6f947e3..50d3090 100644
> > --- a/block/qapi.c
> > +++ b/block/qapi.c
> > @@ -698,6 +698,7 @@ void bdrv_image_info_specific_dump(fprintf_function
> > func_fprintf, void *f,
> > assert(qobject_type(obj) == QTYPE_QDICT);
> > data = qdict_get(qobject_to_qdict(obj), "data");
> > dump_qobject(func_fprintf, f, 1, data);
> > + qobject_decref(obj);
> > visit_free(v);
> > }
>
> The change looks good, but without a Signed-off-by line I can't accept
> the patch: http://wiki.qemu.org/Contribute/SubmitAPatch
D'oh, sorry -- apparently I didn't send the right version... v2 coming.
Thanks,
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.