Re: [Qemu-devel] [PATCH v2 5/6] contrib: add libvhost-user

[Marc-André Lureau]

Hi Felipe

----- Original Message -----
> Hello,
> 
> > On 18 Oct 2016, at 10:24, Marc-André Lureau <address@hidden>
> > wrote:
> > 
> > <...>
> > 
> > diff --git a/contrib/libvhost-user/libvhost-user.h
> > b/contrib/libvhost-user/libvhost-user.h
> > 
> > <...>
> > 
> > +#define VHOST_MAX_NR_VIRTQUEUE 8
> > +#define VIRTQUEUE_MAX_SIZE 1024
> 
> I think that the maximum number of VQs should be 1024 to match Qemu's.
> 
> http://git.qemu.org/?p=qemu.git;a=blob;f=include/hw/virtio/virtio.h;h=b913aac45589449bcc5d8161651332f4b0d69c7f;hb=HEAD#l55

That would make the VuDev structure quite big. We may want to set the nr of max 
queues in vu_init() instead, and allocate it there. I think this is rather a 
current limitation, but does not prevent iterating from there.