Re: [Qemu-devel] [PATCH 1/2] script/clean-includes: added duplicate #include check

[Thomas Huth]

On 18.10.2016 14:38, Anand J wrote:
> 
> 
> On Tue, Oct 18, 2016 at 4:03 PM, Anand J <address@hidden
> <mailto:address@hidden>> wrote:
> 
>     Added script to check duplicate #include entries. This check will scan
>     and print the files in which duplicate #include entries are present.
> 
>     Script might output false positive entries as well. Such entries should
>     not be removed. So if it finds any duplicate entries script will
>     terminate with an exit status 1. Then each and every file should be
>     checked manually and corrected if necessary.
> 
>     In order to enable the check use --check-duphead option with
>     script/clean-includes.
> 
>     Signed-off-by: Anand J <address@hidden
>     <mailto:address@hidden>>
>     ---
>      scripts/clean-includes | 50
>     +++++++++++++++++++++++++++++++++++++-------------
>      1 file changed, 37 insertions(+), 13 deletions(-)

Thanks for the update, this patch looks fine to me now, so feel free to
add my:

Reviewed-by: Thomas Huth <address@hidden>

But please avoid sending patches in HTML e-mails. Could you maybe please
resend the patch as plain text mail? And while you're at it, add CC: to
address@hidden, I think the patch is simple enough to go
through the trivial tree.

 Thanks,
  Thomas