[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] tests/stubs: Add a dummy, silent monitor
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] tests/stubs: Add a dummy, silent monitor |
Date: |
Thu, 20 Oct 2016 09:24:23 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 10/20/2016 05:36 AM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> We need an easy way to silence error_report's that come
> up in meant-to-fail test cases. The easiest way to do
> that is to create a monitor instance, and since our stubbed
> monitor_printf's are slent this causes the errors to disappear.
s/slent/silent/
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> ---
> stubs/mon-is-qmp.c | 9 +++++++++
> tests/libqtest.h | 1 +
> 2 files changed, 10 insertions(+)
>
> diff --git a/stubs/mon-is-qmp.c b/stubs/mon-is-qmp.c
> index a8344ce..012eb28 100644
> --- a/stubs/mon-is-qmp.c
> +++ b/stubs/mon-is-qmp.c
> @@ -2,7 +2,16 @@
> #include "qemu-common.h"
> #include "monitor/monitor.h"
>
> +/* Monitor is defined internally to the real monitor.c, so
s/so/but/
> + * it's real contents are never accessed when stubs are in use;
s/it's/its/ ("it's" is only appropriate if "it is" also works)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature