[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v1 00/10] Merge qio 2016/10/20
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PULL v1 00/10] Merge qio 2016/10/20 |
Date: |
Fri, 21 Oct 2016 11:35:38 +0100 |
On 21 October 2016 at 11:28, Daniel P. Berrange <address@hidden> wrote:
> On Thu, Oct 20, 2016 at 05:11:56PM +0100, Peter Maydell wrote:
>> Unfortunately the new test seems to fail on OSX:
>>
>> GTESTER tests/test-io-channel-socket
>> **
>> ERROR:/Users/pm215/src/qemu-for-merges/tests/test-io-channel-socket.c:386:void
>> test_io_channel_unix(_Bool): assertion failed:
>> (g_file_test(TEST_SOCKET, G_FILE_TEST_EXISTS) == FALSE)
>> GTester: last random seed: R02S300c198252e54fe12ff5d64603150e68
>> **
>> ERROR:/Users/pm215/src/qemu-for-merges/tests/test-io-channel-socket.c:386:void
>> test_io_channel_unix(_Bool): assertion failed:
>> (g_file_test(TEST_SOCKET, G_FILE_TEST_EXISTS) == FALSE)
>> GTester: last random seed: R02S7ade3405366ffc33ad5cf50619671f53
>
> Oh interesting - I've just seen my Travis CI build check also failed
> over night on OS-X.
>
> I wonder if OS-X automatically deletes UNIX non-abstract sockets paths
> on the filesystem when the socket FD is closed ?!?!
The assertion is the other way round, isn't it? It's trying to
assert that the path doesn't exist, but in fact it does
(and it's still lying around in my working tree after the
test failure).
thanks
-- PMM
- [Qemu-devel] [PULL v1 05/10] io: add ability to set a name for IO channels, (continued)
- [Qemu-devel] [PULL v1 05/10] io: add ability to set a name for IO channels, Daniel P. Berrange, 2016/10/20
- [Qemu-devel] [PULL v1 08/10] migration: set name for all I/O channels created, Daniel P. Berrange, 2016/10/20
- [Qemu-devel] [PULL v1 09/10] vnc: set name for all I/O channels created, Daniel P. Berrange, 2016/10/20
- [Qemu-devel] [PULL v1 10/10] main: set names for main loop sources created, Daniel P. Berrange, 2016/10/20
- [Qemu-devel] [PULL v1 07/10] char: set name for all I/O channels created, Daniel P. Berrange, 2016/10/20
- Re: [Qemu-devel] [PULL v1 00/10] Merge qio 2016/10/20, Eric Blake, 2016/10/20
- Re: [Qemu-devel] [PULL v1 00/10] Merge qio 2016/10/20, Peter Maydell, 2016/10/20