[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/9] block: Remove bdrv_aio_pdiscard()
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/9] block: Remove bdrv_aio_pdiscard() |
|
Date: |
Fri, 21 Oct 2016 08:45:27 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 10/21/2016 05:59 AM, Kevin Wolf wrote:
> Am 20.10.2016 um 19:32 hat Eric Blake geschrieben:
>> On 10/20/2016 08:46 AM, Kevin Wolf wrote:
>>> It is unused now.
>>>
>>> Signed-off-by: Kevin Wolf <address@hidden>
>>> ---
>>> block/io.c | 29 -----------------------------
>>> block/trace-events | 1 -
>>> include/block/block.h | 3 ---
>>> 3 files changed, 33 deletions(-)
>>
>> Might be nice to research which commit id removed the last use, and
>> mention it in the commit message as an idea for how long we've had dead
>> code, but that's not a necessity.
>
> Patch 2 removed the last user.
Aha. So maybe "removed in the previous patch" is all the more mention it
needs, if at all.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 1/9] block: Use blk_co_flush() for all BB level flushes, (continued)
- [Qemu-devel] [PATCH 6/9] block: Remove bdrv_ioctl(), Kevin Wolf, 2016/10/20
- [Qemu-devel] [PATCH 8/9] raw: Implement .bdrv_co_ioctl instead of .bdrv_aio_ioctl, Kevin Wolf, 2016/10/20
- [Qemu-devel] [PATCH 5/9] raw-posix: Don't use bdrv_ioctl(), Kevin Wolf, 2016/10/20
- [Qemu-devel] [PATCH 9/9] block: Remove bdrv_aio_ioctl(), Kevin Wolf, 2016/10/20
- Re: [Qemu-devel] [PATCH 0/9] block-backend: Use coroutine for flush/discard/ioctl, Paolo Bonzini, 2016/10/20
- Re: [Qemu-devel] [PATCH 0/9] block-backend: Use coroutine for flush/discard/ioctl, no-reply, 2016/10/20