[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 15/36] qdev: Add "lock-mode" to block device
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v8 15/36] qdev: Add "lock-mode" to block device options |
Date: |
Sat, 22 Oct 2016 02:11:26 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 30.09.2016 14:09, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> hw/core/qdev-properties.c | 10 ++++++++++
> include/hw/block/block.h | 1 +
> include/hw/qdev-properties.h | 3 +++
> 3 files changed, 14 insertions(+)
Why don't you add _conf.lock_mode in this very patch (instead of patch
3) and pull it in front of patch 12? Setting the mode won't do anything
until it's implemented for the various block devices, but I don't think
that's a bad thing.
Max
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v8 15/36] qdev: Add "lock-mode" to block device options,
Max Reitz <=