Re: [Qemu-devel] [PATCH 0/3] baum driver update

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH 0/3] baum driver update
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
c1b3f37 Move getting XWindow ID from baum driver to graphical backend
7ad4f23 Defer BrlAPI tty acquisition to when guest starts using device
fa14666 Add dots keypresses support to the baum braille device

=== OUTPUT BEGIN ===
Checking PATCH 1/3: Add dots keypresses support to the baum braille device...
Checking PATCH 2/3: Defer BrlAPI tty acquisition to when guest starts using 
device...
ERROR: braces {} are necessary for all arms of this statement
#54: FILE: backends/baum.c:250:
+    if (SDL_GetWMInfo(&info))
[...]
+    else
[...]

total: 1 errors, 0 warnings, 119 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/3: Move getting XWindow ID from baum driver to graphical 
backend...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden