[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-error: remove dependency of stubs on monit
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] qemu-error: remove dependency of stubs on monitor |
|
Date: |
Mon, 24 Oct 2016 16:36:14 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 24/10/2016 16:19, Markus Armbruster wrote:
> cur_mon is semantically thread-local: it's non-null while we're
> executing a monitor command. That's a property of the stack, thus the
> thread. The fact that it's not actually thread-local now is a bug I
> blame on inertia.
Or just not noticing it until now.
> Further evidence: if a thread calls error_report(), it should honor
> cur_mon *only* when *this* thread executes a monitor command. It should
> not spew to some unrelated monitor just because some other thread
> happens to execute a monitor command right now.
Yes, that makes sense. I'll work on redoing David's patch on top of
this one then.
Paolo