[Qemu-devel] [PATCH] fixup! qdev: Register static properties as class properties

[Eduardo Habkost]

On Mon, Oct 24, 2016 at 03:53:30PM +0200, Igor Mammedov wrote:
[...]
> > -static void qdev_property_add_legacy(DeviceState *dev, Property *prop,
> > +static void qdev_class_property_add_legacy(ObjectClass *oc, Property *prop,
> >                                       Error **errp)
>                                         ^^^^
> need to fix alignment??
> 
[...]
> > +    object_class_property_add(oc, name, "str",
> > +                               prop->info->print ?
> alignment off by 1 starting from here?


Fixup below.

I can resend the whole series if necessary. Whoever is going to
merge this, just let me know.

---
 hw/core/qdev.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index f7d9030..a88753c 100644
--- a/hw/core/qdev.c
+++ b/hw/core/qdev.c
@@ -755,7 +755,7 @@ static void qdev_get_legacy_property(Object *obj, Visitor 
*v,
  * will be given names in the "legacy" namespace.
  */
 static void qdev_class_property_add_legacy(ObjectClass *oc, Property *prop,
-                                     Error **errp)
+                                           Error **errp)
 {
     gchar *name;
 
@@ -766,12 +766,12 @@ static void qdev_class_property_add_legacy(ObjectClass 
*oc, Property *prop,
 
     name = g_strdup_printf("legacy-%s", prop->name);
     object_class_property_add(oc, name, "str",
-                               prop->info->print ?
-                                   qdev_get_legacy_property :
-                                   prop->info->get,
-                               NULL,
-                               NULL,
-                               prop, errp);
+                              prop->info->print ?
+                                  qdev_get_legacy_property :
+                                  prop->info->get,
+                              NULL,
+                              NULL,
+                              prop, errp);
 
     g_free(name);
 }
-- 
2.7.4