[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 15/17] support replication driver in blockdev-add
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PULL 15/17] support replication driver in blockdev-add |
Date: |
Tue, 25 Oct 2016 16:31:19 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 09/12/2016 09:08 AM, Stefan Hajnoczi wrote:
> From: Wen Congyang <address@hidden>
>
> Signed-off-by: Wen Congyang <address@hidden>
> Signed-off-by: Changlong Xie <address@hidden>
> Signed-off-by: Wang WeiWei <address@hidden>
> Signed-off-by: zhanghailiang <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> Message-id: address@hidden
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> qapi/block-core.json | 23 +++++++++++++++++++++--
> 1 file changed, 21 insertions(+), 2 deletions(-)
>
> +++ b/qapi/block-core.json
> @@ -252,6 +252,7 @@
> # 2.3: 'host_floppy' deprecated
> # 2.5: 'host_floppy' dropped
> # 2.6: 'luks' added
> +# 2.8: 'replication' added
You added documentation here...
> #
> # @backing_file: #optional the name of the backing file (for copy-on-write)
> #
> @@ -1712,8 +1713,8 @@
...but not for the BlockdevDriver enum.
> 'data': [ 'archipelago', 'blkdebug', 'blkverify', 'bochs', 'cloop',
> 'dmg', 'file', 'ftp', 'ftps', 'gluster', 'host_cdrom',
> 'host_device', 'http', 'https', 'luks', 'null-aio', 'null-co',
> - 'parallels', 'qcow', 'qcow2', 'qed', 'quorum', 'raw', 'tftp',
> - 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] }
> + 'parallels', 'qcow', 'qcow2', 'qed', 'quorum', 'raw',
> + 'replication', 'tftp', 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] }
Also, I failed to notice that you added TAB damage here. Other patches
are currently proposed to touch the same area (nfs, ssh, nbd), so
hopefully one of them will correct it in the process.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PULL 15/17] support replication driver in blockdev-add,
Eric Blake <=