[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm g
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests |
Date: |
Wed, 26 Oct 2016 12:26:48 -0200 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Wed, Oct 26, 2016 at 11:32:56AM +0100, Wei Liu wrote:
> On Tue, Oct 25, 2016 at 04:33:03PM -0700, Stefano Stabellini wrote:
> > CC'ing maintainers
> >
> > On Tue, 25 Oct 2016, Wei Liu wrote:
> > > Xen's toolstack is in charge of building ACPI tables. Skip acpi table
> > > building if running on Xen.
> > >
> > > This issue is discovered due to direct kernel boot on Xen doesn't boot
> > > anymore, because the new ACPI tables cause the guest to exceed its
> > > memory allocation limit.
> > >
> > > Reported-by: Sander Eikelenboom <address@hidden>
> > > Signed-off-by: Wei Liu <address@hidden>
> >
> > Hi Wei,
> > thanks for the patch. I think the right fix is to set
> >
> > pcmc->has_acpi_build = false
> >
> > for the xenfv machine and for the PC machine when accel=xen.
> >
> > Thoughts?
> >
>
> This sounds like a better idea to me.
As we shouldn't change PCMachineClass::has_acpi_build outside
class_init, to make accel=xen disable it you'll probably need a
new PCMachineState field.
--
Eduardo
- [Qemu-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests, Wei Liu, 2016/10/25
- Re: [Qemu-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests, Stefano Stabellini, 2016/10/25
- Re: [Qemu-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests, Igor Mammedov, 2016/10/26
- Re: [Qemu-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests, Wei Liu, 2016/10/26
- Re: [Qemu-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests, Igor Mammedov, 2016/10/27
- Re: [Qemu-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests, Igor Mammedov, 2016/10/27
- Re: [Qemu-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests, Wei Liu, 2016/10/27
- Re: [Qemu-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests, Wei Liu, 2016/10/27
- Re: [Qemu-devel] [Xen-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests, Igor Mammedov, 2016/10/27
- Re: [Qemu-devel] [Xen-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests, Wei Liu, 2016/10/27