Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 10/17] COLO: Add checkpoint-delay parameter for migrate-set-parameters

[Hailiang Zhang]

On 2016/10/26 13:45, Amit Shah wrote:
> On (Tue) 18 Oct 2016 [20:10:06], zhanghailiang wrote:
> > Add checkpoint-delay parameter for migrate-set-parameters, so that
> > we can control the checkpoint frequency when COLO is in periodic mode.
> >
> > Cc: Luiz Capitulino <address@hidden>
> > Cc: Eric Blake <address@hidden>
> > Cc: Markus Armbruster <address@hidden>
> > Signed-off-by: zhanghailiang <address@hidden>
> > Signed-off-by: Li Zhijian <address@hidden>
> > Reviewed-by: Dr. David Alan Gilbert <address@hidden>
>
>
> > diff --git a/hmp.c b/hmp.c
> > index 80f7f1f..759f4f4 100644
> > --- a/hmp.c
> > +++ b/hmp.c
> > @@ -318,6 +318,9 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict 
> > *qdict)
> >           monitor_printf(mon, " %s: %" PRId64 " milliseconds",
> >               MigrationParameter_lookup[MIGRATION_PARAMETER_DOWNTIME_LIMIT],
> >               params->downtime_limit);
> > +        monitor_printf(mon, " %s: %" PRId64,
> > +            MigrationParameter_lookup[MIGRATION_PARAMETER_X_CHECKPOINT_DELAY],
> > +            params->x_checkpoint_delay);
> >           monitor_printf(mon, "\n");
> >       }
> >
> > @@ -1363,7 +1366,6 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict 
> > *qdict)
> >               case MIGRATION_PARAMETER_CPU_THROTTLE_INCREMENT:
> >                   p.has_cpu_throttle_increment = true;
> >                   use_int_value = true;
> > -                break;
>
> Hm?

Oops, It seems that i remove it accidently while rebase to upstream.
I'll fix it in next version, thanks

> >               case MIGRATION_PARAMETER_TLS_CREDS:
> >                   p.has_tls_creds = true;
> >                   p.tls_creds = (char *) valuestr;
> > @@ -1386,6 +1388,10 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict 
> > *qdict)
>
>
>                 Amit
>
> .