Re: [Qemu-devel] [PATCH v2 3/6] qdev: Register static properties as class properties

[Igor Mammedov]

On Thu, 20 Oct 2016 15:47:56 -0200
Eduardo Habkost <address@hidden> wrote:

> Instead of registering qdev static properties on instance_init,
> register them as class properties, at qdev_class_set_props().
> 
> qdev_property_add_legacy() was replaced by an equivalent
> qdev_class_property_add_legacy() function.
> qdev_property_add_static(), on the other hand, can't be
> eliminated yet because it is used by arm_cpu_post_init().
> 
> Signed-off-by: Eduardo Habkost <address@hidden>
on make check, I'm getting after
 [1/1 has been regenerated using script from commit message]


hw/core/qdev.c:1063: device_class_set_props: Assertion `!dc->props' failed.


/me using ./configure  without options on RHEL7

> ---
>  hw/core/qdev.c | 69 
> ++++++++++++++++++++++++++++++++++++++++++++++++----------
>  1 file changed, 58 insertions(+), 11 deletions(-)
> 
> diff --git a/hw/core/qdev.c b/hw/core/qdev.c
> index 85952e8..f7d9030 100644
> --- a/hw/core/qdev.c
> +++ b/hw/core/qdev.c
> @@ -739,12 +739,12 @@ static void qdev_get_legacy_property(Object *obj, 
> Visitor *v,
>  }
>  
>  /**
> - * qdev_property_add_legacy:
> - * @dev: Device to add the property to.
> + * qdev_class_property_add_legacy:
> + * @oc: Device to add the property to.
one more thing to fix:

s/Device/object class/