qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 8/8] qdev: Warning about using object_class_p


From: Eduardo Habkost
Subject: Re: [Qemu-devel] [PATCH v3 8/8] qdev: Warning about using object_class_property_add() in new code
Date: Wed, 26 Oct 2016 14:57:53 -0200
User-agent: Mutt/1.7.0 (2016-08-17)

On Wed, Oct 26, 2016 at 05:48:03PM +0100, Peter Maydell wrote:
> On 26 October 2016 at 17:30, Eduardo Habkost <address@hidden> wrote:
> > The only remaining user of object_class_property_add() is
> > arm_cpu_post_init(), but removing it may take some work. While we
> > don't change it, warn people to not use the function in new code.
> 
> This is about the third time I've seen this commit
> message go past, but:
> 
>   git grep object_class_property_add target-arm   => no hits

Erm. I meant qdev_property_add_static(). Sorry.

target-arm/cpu.c:        qdev_property_add_static(DEVICE(obj), 
&arm_cpu_reset_cbar_property,
target-arm/cpu.c:        qdev_property_add_static(DEVICE(obj), 
&arm_cpu_reset_hivecs_property,
target-arm/cpu.c:        qdev_property_add_static(DEVICE(obj), 
&arm_cpu_rvbar_property,
target-arm/cpu.c:        qdev_property_add_static(DEVICE(obj), 
&arm_cpu_has_el3_property,
target-arm/cpu.c:        qdev_property_add_static(DEVICE(obj), 
&arm_cpu_has_mpu_property,
target-arm/cpu.c:            qdev_property_add_static(DEVICE(obj),

Commit message needs to be rewritten as:

    qdev: Warning about using qdev_property_add_static() in new code
    
    The only remaining user of qdev_property_add_static() is
    arm_cpu_post_init(), but removing it may take some work. While we
    don't change it, warn people to not use the function in new code.

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]