[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] raw-posix: Rename 'raw_s' to 'rs'
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] raw-posix: Rename 'raw_s' to 'rs' |
Date: |
Thu, 27 Oct 2016 09:28:36 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 10/27/2016 05:45 AM, Fam Zheng wrote:
> It is too confusing because it sounds like a BDRVRawState variable.
>
> Suggested-by: Max Reitz <address@hidden>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> block/raw-posix.c | 56
> +++++++++++++++++++++++++++----------------------------
> 1 file changed, 28 insertions(+), 28 deletions(-)
>
> diff --git a/block/raw-posix.c b/block/raw-posix.c
> index f481e57..7c62fc3 100644
> --- a/block/raw-posix.c
> +++ b/block/raw-posix.c
> @@ -542,7 +542,7 @@ static int raw_reopen_prepare(BDRVReopenState *state,
> BlockReopenQueue *queue, Error **errp)
> {
> BDRVRawState *s;
> - BDRVRawReopenState *raw_s;
> + BDRVRawReopenState *rs;
Would rrs (Raw Reopen State) be any better? But you can ignore my
bikeshedding. The patch is mechanical, so either spelling gets:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature