[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] Move getting XWindow ID from baum driver to
From: |
Samuel Thibault |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] Move getting XWindow ID from baum driver to graphical backend |
Date: |
Sun, 30 Oct 2016 16:24:04 +0100 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Gerd Hoffmann, on Wed 26 Oct 2016 12:17:44 +0200, wrote:
> > + /* All consoles share the same window */
>
> No. That is the default setup, but try "View / Detach tab". Window ID
> changing at runtime ...
So we would need to make baum register for notification of Window ID
change.
It could be a mere
typedef void QemuConsoleWindowIDListener(void);
qemu_console_window_id_add_listener(QemuConsoleWindowIDListener listener);
qemu_console_window_id_remove_listener(QemuConsoleWindowIDListener listener);
that adds/removes the listener to a list to be called when
qemu_console_set_window_id is called.
Or we could generalize a bit:
typedef void QemuConsoleConfigListener(void);
qemu_console_config_add_listener(QemuConsoleConfigListener listener);
qemu_console_config_remove_listener(QemuConsoleConfigListener listener);
Or even more generalized:
struct QemuConsoleListener {
void (*window_id)(void);
};
typedef struct QemuConsoleListener QemuConsoleListener;
qemu_console_add_listener(QemuConsoleListener *listener);
qemu_console_remove_listener(QemuConsoleListener *listener);
What would be preferrable?
Samuel
[Qemu-devel] [PATCH 2/3] Defer BrlAPI tty acquisition to when guest starts using device, Samuel Thibault, 2016/10/23