|
From: | Hailiang Zhang |
Subject: | Re: [Qemu-devel] [PULL 10/18] COLO: Add checkpoint-delay parameter for migrate-set-parameters |
Date: | Tue, 1 Nov 2016 10:10:35 +0800 |
User-agent: | Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 |
On 2016/11/1 1:17, Juan Quintela wrote:
Amit Shah <address@hidden> wrote:From: zhanghailiang <address@hidden> Add checkpoint-delay parameter for migrate-set-parameters, so that we can control the checkpoint frequency when COLO is in periodic mode. @@ -587,6 +593,7 @@ MigrationParameters *qmp_query_migrate_parameters(Error **errp) params->max_bandwidth = s->parameters.max_bandwidth; params->has_downtime_limit = true; params->downtime_limit = s->parameters.downtime_limit; + params->x_checkpoint_delay = s->parameters.x_checkpoint_delay; return params; }I think you are missing here: params->has_x_checkpoint_delay = true;
Good catch, this will influence output of qmp command 'query-migrate-parameters'. (Without this, 'query-migrate-parameters' command will shows no "x-checkpoint-delay": 200) I will send a patch to fix it, thanks very much. Hailiang
No? Later, Juan .
[Prev in Thread] | Current Thread | [Next in Thread] |