Re: [Qemu-devel] [PATCH v5 28/33] cputlb: make tlb_flush_by_mmuidx safe for MTTCG

[Peter Maydell]

On 1 November 2016 at 07:45, Alex Bennée <address@hidden> wrote:
>
> Pranith Kumar <address@hidden> writes:
>> FYI, this is causing a build error on my system with gcc 6.2.
>>
>>   CC      aarch64-softmmu/cputlb.o
>> In file included from 
>> /home/pranith/devops/code/qemu/include/qemu/osdep.h:36:0,
>>                  from /home/pranith/devops/code/qemu/cputlb.c:20:
>> /home/pranith/devops/code/qemu/include/exec/cpu-all.h:196:26: error: 
>> braced-group within expression allowed only inside a function
>>  #define TARGET_PAGE_BITS ({ assert(target_page_bits_decided); \
>>                           ^
>> /home/pranith/devops/code/qemu/include/qemu/compiler.h:89:54: note: in 
>> definition of macro ‘QEMU_BUILD_BUG_ON’
>>      typedef char glue(qemu_build_bug_on__,__LINE__)[(x)?-1:1] 
>> __attribute__((unused));
>>                                                       ^
>> /home/pranith/devops/code/qemu/cputlb.c:293:34: note: in expansion of macro 
>> ‘TARGET_PAGE_BITS’
>>  QEMU_BUILD_BUG_ON(NB_MMU_MODES > TARGET_PAGE_BITS);
>>                                   ^~~~~~~~~~~~~~~~
>> /home/pranith/devops/code/qemu/rules.mak:60: recipe for target 'cputlb.o' 
>> failed
>> make[1]: *** [cputlb.o] Error 1
>> Makefile:202: recipe for target 'subdir-aarch64-softmmu' failed
>> make: *** [subdir-aarch64-softmmu] Error 2
>
> Odd. I'll look into it. What was you configure string and host architecture?

Looks like a clash between the variable-page-size patchset
and your stuff. Now TARGET_PAGE_BITS isn't necessarily
constant you can't use it in a compile time assert like that.

thanks
-- PMM