[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 07/14] block/gluster: fix port type in the QAPI op
From: |
Jeff Cody |
Subject: |
[Qemu-devel] [PULL v2 07/14] block/gluster: fix port type in the QAPI options list |
Date: |
Tue, 1 Nov 2016 08:51:04 -0400 |
From: Prasanna Kumar Kalever <address@hidden>
After introduction of qapi schema in gluster block driver code, the port
type is now string as per InetSocketAddress
{ 'struct': 'InetSocketAddress',
'data': {
'host': 'str',
'port': 'str',
'*to': 'uint16',
'*ipv4': 'bool',
'*ipv6': 'bool' } }
but the current code still treats it as QEMU_OPT_NUMBER, hence fixing port
to accept QEMU_OPT_STRING.
Suggested-by: Markus Armbruster <address@hidden>
Signed-off-by: Prasanna Kumar Kalever <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
Signed-off-by: Jeff Cody <address@hidden>
---
block/gluster.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/gluster.c b/block/gluster.c
index 98a9132..0ce15f7 100644
--- a/block/gluster.c
+++ b/block/gluster.c
@@ -186,7 +186,7 @@ static QemuOptsList runtime_tcp_opts = {
},
{
.name = GLUSTER_OPT_PORT,
- .type = QEMU_OPT_NUMBER,
+ .type = QEMU_OPT_STRING,
.help = "port number on which glusterd is listening (default
24007)",
},
{
--
2.7.4
- [Qemu-devel] [PULL v2 00/14] Block patches for 2.8, Jeff Cody, 2016/11/01
- [Qemu-devel] [PULL v2 02/14] rbd: make the code more readable, Jeff Cody, 2016/11/01
- [Qemu-devel] [PULL v2 01/14] qapi: add release designator to gluster logfile option, Jeff Cody, 2016/11/01
- [Qemu-devel] [PULL v2 05/14] block: Turn on "unmap" in active commit, Jeff Cody, 2016/11/01
- [Qemu-devel] [PULL v2 04/14] block/gluster: memory usage: use one glfs instance per volume, Jeff Cody, 2016/11/01
- [Qemu-devel] [PULL v2 07/14] block/gluster: fix port type in the QAPI options list,
Jeff Cody <=
- [Qemu-devel] [PULL v2 03/14] block: add gluster ifdef guard checks for SEEK_DATA/SEEK_HOLE support, Jeff Cody, 2016/11/01
- [Qemu-devel] [PULL v2 06/14] block/gluster: improve defense over string to int conversion, Jeff Cody, 2016/11/01
- [Qemu-devel] [PULL v2 08/14] blockjobs: hide internal jobs from management API, Jeff Cody, 2016/11/01
- [Qemu-devel] [PULL v2 10/14] Replication/Blockjobs: Create replication jobs as internal, Jeff Cody, 2016/11/01
- [Qemu-devel] [PULL v2 12/14] Blockjobs: Internalize user_pause logic, Jeff Cody, 2016/11/01
- [Qemu-devel] [PULL v2 09/14] blockjobs: Allow creating internal jobs, Jeff Cody, 2016/11/01
- [Qemu-devel] [PULL v2 14/14] blockjobs: fix documentation, Jeff Cody, 2016/11/01
- [Qemu-devel] [PULL v2 11/14] blockjob: centralize QMP event emissions, Jeff Cody, 2016/11/01
- [Qemu-devel] [PULL v2 13/14] blockjobs: split interface into public/private, Part 1, Jeff Cody, 2016/11/01
- Re: [Qemu-devel] [PULL v2 00/14] Block patches for 2.8, no-reply, 2016/11/01