Re: [Qemu-devel] [PULL 6/6] curses: Use cursesw instead of curses

[Cornelia Huck]

On Mon, 31 Oct 2016 16:39:29 +0100
Samuel Thibault <address@hidden> wrote:

> Cornelia Huck, on Mon 31 Oct 2016 14:08:48 +0100, wrote:
> > On Mon, 31 Oct 2016 15:03:33 +0100
> > Samuel Thibault <address@hidden> wrote:
> > 
> > > Cornelia Huck, on Mon 31 Oct 2016 13:48:01 +0100, wrote:
> > > > On Mon, 31 Oct 2016 13:39:30 +0100
> > > > Samuel Thibault <address@hidden> wrote:
> > > > 
> > > > > Cornelia Huck, on Mon 31 Oct 2016 13:08:06 +0100, wrote:
> > > > > > You mean in configure, right? Including cursesw.h in the test 
> > > > > > program
> > > > > > gets configure going again.
> > > > > 
> > > > > Could you try the attached patch which fixes both configure and
> > > > > ui/curses.c?
> > > > 
> > > > Sadly, this does not fix it for me. I get the same errors in the
> > > > configure test build as before.
> > > 
> > > Could you post the config.log so we get a better view at what is going
> > > wrong?
> > 
> > Attached.
> 
> > cc -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE 
> > -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings 
> > -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv 
> > -Wendif-labels -Wmissing-include-dirs -Wempty-body -Wnested-externs 
> > -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers 
> > -Wold-style-declaration -Wold-style-definition -Wtype-limits 
> > -fstack-protector-all -I/usr/include/libpng16 -o config-temp/qemu-conf.exe 
> > config-temp/qemu-conf.c -m64 -g
> > config-temp/qemu-conf.c: In function ‘main’:
> > config-temp/qemu-conf.c:13:3: warning: implicit declaration of function 
> > ‘addwstr’ [-Wimplicit-function-declaration]
> ...
> > cc -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE 
> > -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings 
> > -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv 
> > -Wendif-labels -Wmissing-include-dirs -Wempty-body -Wnested-externs 
> > -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers 
> > -Wold-style-declaration -Wold-style-definition -Wtype-limits 
> > -fstack-protector-all -I/usr/include/libpng16 -o config-temp/qemu-conf.exe 
> > config-temp/qemu-conf.c -m64 -g -lncursesw
> > config-temp/qemu-conf.c: In function ‘main’:
> > config-temp/qemu-conf.c:13:3: warning: implicit declaration of function 
> > ‘addwstr’ [-Wimplicit-function-declaration]
> ...
> > cc -Werror -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE 
> > -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings 
> > -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv 
> > -Wendif-labels -Wmissing-include-dirs -Wempty-body -Wnested-externs 
> > -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers 
> > -Wold-style-declaration -Wold-style-definition -Wtype-limits 
> > -fstack-protector-all -I/usr/include/libpng16 -o config-temp/qemu-conf.exe 
> > config-temp/qemu-conf.c -m64 -g -lncursesw
> > config-temp/qemu-conf.c: In function ‘main’:
> > config-temp/qemu-conf.c:13:3: error: implicit declaration of function 
> > ‘addwstr’ [-Werror=implicit-function-declaration]
> >    addwstr(L"wide chars\n");
> >    ^
> > config-temp/qemu-conf.c:13:3: error: nested extern declaration of ‘addwstr’ 
> > [-Werror=nested-externs]
> > config-temp/qemu-conf.c:14:3: error: implicit declaration of function 
> > ‘addnwstr’ [-Werror=implicit-function-declaration]
> >    addnwstr(&wch, 1);
> >    ^
> > config-temp/qemu-conf.c:14:3: error: nested extern declaration of 
> > ‘addnwstr’ [-Werror=nested-externs]
> > cc1: all warnings being treated as errors
> 
> These are expected
> 
> But doesn't configure also try with -DCONFIG_CURSESW_H?  Does it really
> stop here?

Nothing more going on there. Maybe it is because it cannot pull the
relevant flags from pkg_config?