[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.8] block: Don't mark node clean after fail
|
From: |
Denis V. Lunev |
|
Subject: |
Re: [Qemu-devel] [PATCH for-2.8] block: Don't mark node clean after failed flush |
|
Date: |
Sat, 5 Nov 2016 02:45:04 +0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 11/05/2016 02:03 AM, Kevin Wolf wrote:
> Commit 3ff2f67a changed bdrv_co_flush() so that no flush is issues if
> the image hasn't been dirtied since the last flush. This is not quite
> correct: The condition should be that the image hasn't been dirtied
> since the last _successful_ flush. This patch changes the logic
> accordingly.
>
> Without this fix, subsequent bdrv_co_flush() calls would return success
> without actually doing anything even though the image is still dirty.
> The difference is visible in some blkdebug test cases where error
> messages incorrectly disappeared after commit 3ff2f67a.
>
> Cc: address@hidden
> Signed-off-by: Kevin Wolf <address@hidden>
good catch!
Reviewed-by: Denis V. Lunev <address@hidden>