[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/6] block-backend: Always notify on blk_ejec
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/6] block-backend: Always notify on blk_eject |
Date: |
Mon, 7 Nov 2016 16:01:48 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 11/07/2016 03:13 PM, John Snow wrote:
> blk_eject is only used by scsi-disk and atapi, and in both cases we
> only attempt to invoke blk_eject if we have a bona-fide change in
> tray state.
>
> The "issue" here is that the tray state does not generate a QMP event
> unless there is a medium/BDS attached to the device, so if libvirt et al
> are waiting for a tray event to occur from an empty-but-closed drive,
> software opening that drive will not emit an event and libvirt will
> wait forever.
>
> Change this by modifying blk_eject to always emit an event, instead of
> conditionally on a "real" backend eject.
>
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1373264
>
> Reported-by: Peter Krempa <address@hidden>
> Signed-off-by: John Snow <address@hidden>
> ---
> block/block-backend.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 0/6] block-backend: Always notify on blk_eject, John Snow, 2016/11/07
- [Qemu-devel] [PATCH v2 4/6] libqos/ahci: Add ATAPI tray macros, John Snow, 2016/11/07
- [Qemu-devel] [PATCH v2 3/6] libqos/ahci: Support expected errors, John Snow, 2016/11/07
- [Qemu-devel] [PATCH v2 1/6] block-backend: Always notify on blk_eject, John Snow, 2016/11/07
- Re: [Qemu-devel] [PATCH v2 1/6] block-backend: Always notify on blk_eject,
Eric Blake <=
- [Qemu-devel] [PATCH v2 5/6] libqos/ahci: Add get_sense and test_ready, John Snow, 2016/11/07
- [Qemu-devel] [PATCH v2 2/6] libqtest: add qmp_eventwait_ref, John Snow, 2016/11/07
- [Qemu-devel] [PATCH v2 6/6] ahci-test: add QMP tray test for ATAPI, John Snow, 2016/11/07
- Re: [Qemu-devel] [PATCH v2 0/6] block-backend: Always notify on blk_eject, John Snow, 2016/11/10
- Re: [Qemu-devel] [PATCH v2 0/6] block-backend: Always notify on blk_eject, Kevin Wolf, 2016/11/11