Re: [Qemu-devel] [PATCH v11 02/22] vfio: VFIO based driver for Mediated devices

[Dong Jia Shi]

* Kirti Wankhede <address@hidden> [2016-11-05 02:40:36 +0530]:

Hi Kirti,

> vfio_mdev driver registers with mdev core driver.
> mdev core driver creates mediated device and calls probe routine of
> vfio_mdev driver for each device.
> Probe routine of vfio_mdev driver adds mediated device to VFIO core module
> 
> This driver forms a shim layer that pass through VFIO devices operations
> to vendor driver for mediated devices.
> 
> Signed-off-by: Kirti Wankhede <address@hidden>
> Signed-off-by: Neo Jia <address@hidden>
> Change-Id: I583f4734752971d3d112324d69e2508c88f359ec
> ---
>  drivers/vfio/mdev/Kconfig     |   9 ++-
>  drivers/vfio/mdev/Makefile    |   1 +
>  drivers/vfio/mdev/vfio_mdev.c | 148 
> ++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 157 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/vfio/mdev/vfio_mdev.c
> 
> diff --git a/drivers/vfio/mdev/Kconfig b/drivers/vfio/mdev/Kconfig
> index 303c14ce2847..79c9cface7b1 100644
> --- a/drivers/vfio/mdev/Kconfig
> +++ b/drivers/vfio/mdev/Kconfig
> @@ -5,6 +5,13 @@ config VFIO_MDEV
>      default n
>      help
>          Provides a framework to virtualize devices.
> -     See Documentation/vfio-mdev/vfio-mediated-device.txt for more details.
> +     See Documentation/vfio-mediated-device.txt for more details.
So patch #01 has a wrong doc path.

> 
>          If you don't know what do here, say N.
> +
> +config VFIO_MDEV_DEVICE
> +    tristate "VFIO support for Mediated devices"
> +    depends on VFIO && VFIO_MDEV
> +    default n
> +    help
> +        VFIO based driver for mediated devices.
I just think the names of the config entries here are a bit strange, but
I'm not sure if there is a better way. Maybe (?):
s/VFIO_MDEV/VFIO_MDEV_SUPPORT/
s/VFIO_MDEV_DEVICE/VFIO_MDEV/

> diff --git a/drivers/vfio/mdev/Makefile b/drivers/vfio/mdev/Makefile
> index 31bc04801d94..fa2d5ea466ee 100644
> --- a/drivers/vfio/mdev/Makefile
> +++ b/drivers/vfio/mdev/Makefile
> @@ -2,3 +2,4 @@
>  mdev-y := mdev_core.o mdev_sysfs.o mdev_driver.o
> 
>  obj-$(CONFIG_VFIO_MDEV) += mdev.o
> +obj-$(CONFIG_VFIO_MDEV_DEVICE) += vfio_mdev.o
> diff --git a/drivers/vfio/mdev/vfio_mdev.c b/drivers/vfio/mdev/vfio_mdev.c
[...]

> +
> +MODULE_VERSION(DRIVER_VERSION);
> +MODULE_LICENSE("GPL");
?
GPL V2

> +MODULE_AUTHOR(DRIVER_AUTHOR);
> +MODULE_DESCRIPTION(DRIVER_DESC);
> -- 
> 2.7.0
> 

-- 
Dong Jia