[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2] cipher: fix leak on initialization error
|
From: |
Daniel P. Berrange |
|
Subject: |
Re: [Qemu-devel] [PATCHv2] cipher: fix leak on initialization error |
|
Date: |
Wed, 9 Nov 2016 10:30:05 +0000 |
|
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Wed, Nov 09, 2016 at 02:28:18PM +0400, Marc-André Lureau wrote:
> On error path, ctx may be leaked. Assign ctx earlier, and call
> qcrypto_cipher_free() on error.
>
> Spotted thanks to ASAN.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> crypto/cipher-nettle.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Thanks, queued on my crypto-next branch
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|