[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 4/6] blockjob: add block_job_start
From: |
Jeff Cody |
Subject: |
Re: [Qemu-devel] [PATCH v4 4/6] blockjob: add block_job_start |
Date: |
Wed, 9 Nov 2016 11:18:58 -0500 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Tue, Nov 08, 2016 at 01:50:37AM -0500, John Snow wrote:
> Instead of automatically starting jobs at creation time via backup_start
> et al, we'd like to return a job object pointer that can be started
> manually at later point in time.
>
> For now, add the block_job_start mechanism and start the jobs
> automatically as we have been doing, with conversions job-by-job coming
> in later patches.
>
> Of note: cancellation of unstarted jobs will perform all the normal
> cleanup as if the job had started, particularly abort and clean. The
> only difference is that we will not emit any events, because the job
> never actually started.
>
> Signed-off-by: John Snow <address@hidden>
> ---
> block/backup.c | 3 +--
> block/commit.c | 5 ++---
> block/mirror.c | 5 ++---
> block/stream.c | 5 ++---
> block/trace-events | 6 +++---
> blockjob.c | 54
> ++++++++++++++++++++++++++++++++++++-----------
> include/block/blockjob.h | 9 ++++++++
> tests/test-blockjob-txn.c | 12 +++++------
> 8 files changed, 67 insertions(+), 32 deletions(-)
>
Reviewed-by: Jeff Cody <address@hidden>
- [Qemu-devel] [PATCH v4 0/6] jobs: fix transactional race condition, John Snow, 2016/11/08
- [Qemu-devel] [PATCH v4 2/6] blockjob: add .clean property, John Snow, 2016/11/08
- [Qemu-devel] [PATCH v4 3/6] blockjob: add .start field, John Snow, 2016/11/08
- [Qemu-devel] [PATCH v4 4/6] blockjob: add block_job_start, John Snow, 2016/11/08
- Re: [Qemu-devel] [PATCH v4 4/6] blockjob: add block_job_start,
Jeff Cody <=
- [Qemu-devel] [PATCH v4 6/6] iotests: add transactional failure race test, John Snow, 2016/11/08
- [Qemu-devel] [PATCH v4 1/6] blockjob: fix dead pointer in txn list, John Snow, 2016/11/08
- [Qemu-devel] [PATCH v4 5/6] blockjob: refactor backup_start as backup_job_create, John Snow, 2016/11/08
- Re: [Qemu-devel] [PATCH v4 0/6] jobs: fix transactional race condition, Jeff Cody, 2016/11/09
- Re: [Qemu-devel] [PATCH v4 0/6] jobs: fix transactional race condition, Jeff Cody, 2016/11/09
- Re: [Qemu-devel] [PATCH v4 0/6] jobs: fix transactional race condition, John Snow, 2016/11/14