[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [TRIVIAL][RFC][PATCH] FU exceptions should carry a caus
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [TRIVIAL][RFC][PATCH] FU exceptions should carry a cause (IC) |
Date: |
Thu, 10 Nov 2016 13:06:17 +1100 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Thu, Nov 10, 2016 at 12:42:37PM +1100, Balbir Singh wrote:
>
>
> As per the ISA we need a cause for FU exceptions.Executing a tabort r9
> for example in libc, causes a EXCP_FU exception. We don't wire up the
> IC (cause) when we post the exception. The cause is required
> for the kernel to do the right thing. I caught this issue while testing
> the latest kernel against Cedrics' latest pnv ipmi branch.
>
> Signed-off-by: Balbir singh <address@hidden>
Applied to ppc-for-2.8
> ---
> target-ppc/excp_helper.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target-ppc/excp_helper.c b/target-ppc/excp_helper.c
> index 808760b..cccea8d 100644
> --- a/target-ppc/excp_helper.c
> +++ b/target-ppc/excp_helper.c
> @@ -427,6 +427,7 @@ static inline void powerpc_excp(PowerPCCPU *cpu, int
> excp_model, int excp)
> case POWERPC_EXCP_VPU: /* Vector unavailable exception
> */
> case POWERPC_EXCP_VSXU: /* VSX unavailable exception
> */
> case POWERPC_EXCP_FU: /* Facility unavailable exception
> */
> + env->spr[SPR_FSCR] |= ((target_ulong)env->error_code << 56);
> break;
> case POWERPC_EXCP_PIT: /* Programmable interval timer interrupt
> */
> LOG_EXCP("PIT exception\n");
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature