Re: [Qemu-devel] [kvm-unit-tests PATCH v5 10/11] arm/arm64: gicv3: add an IPI test

[Alex Bennée]

Andre Przywara <address@hidden> writes:

> Hi,
>
> On 10/11/16 19:53, Alex Bennée wrote:
>
> ....
>> So I was re-basing my kvm-unit-tests against your GIC rework and found
>> myself copy and pasting a bunch of this into my tests that fire IRQs.
>
> So I take it you are working on (or already have) code to test SPIs,
> probably via GICD_ISPENDR?
> Just asking because I was thinking about going there and thus could save
> my time if you are on it already...

In my case I wanted to trigger SPIs to exercise my TCG tests for MTTCG:

  
https://github.com/stsquad/kvm-unit-tests/blob/mttcg/current-tests-v6/arm/tcg-test.c#L113

>> That makes me think the abstraction should be in the library code so
>> other tests can fiddle with sending IRQs.
>
> ...because I was wondering the same.

To answer Andrew's question from the other post I would be happy with a
common:

  gic_enable
  gic_send_spi(cpu, irq)
  gic_irq_ack() which returns the iar.


>
> Cheers,
> Andre.


--
Alex Bennée