[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 5/5] Plumb the HAXM-based hardware accelerati
From: |
Vincent Palatin |
Subject: |
Re: [Qemu-devel] [PATCH v2 5/5] Plumb the HAXM-based hardware acceleration support |
Date: |
Mon, 14 Nov 2016 13:09:50 +0100 |
On Mon, Nov 14, 2016 at 12:56 PM, Paolo Bonzini <address@hidden> wrote:
>
>
> On 11/11/2016 12:28, Vincent Palatin wrote:
>> + /*
>> + * In Hax, the qemu allocate the virtual address, and HAX kernel
>> + * populate the memory with physical memory. Currently we have
>> no
>> + * paging, so user should make sure enough free memory in
>> advance
>> + */
>> + if (hax_enabled()) {
>> + int ret;
>> + ret = hax_populate_ram((uint64_t)(uintptr_t)new_block->host,
>> + new_block->max_length);
>> + if (ret < 0) {
>> + error_setg(errp, "Hax failed to populate ram");
>> + return;
>> + }
>> + }
>> +
>> if (!new_block->host) {
>> error_setg_errno(errp, errno,
>> "cannot set up guest memory '%s'",
>
> The hax_enabled() check should be after the "if (!new_block->host)" block.
Indeed, fixed in v3 series.
Thansk !
--
Vincent
- [Qemu-devel] [PATCH v2 3/5] hax: remove non UG code, (continued)
- [Qemu-devel] [PATCH v2 3/5] hax: remove non UG code, Vincent Palatin, 2016/11/11
- [Qemu-devel] [PATCH v2 4/5] hax: simplify init, Vincent Palatin, 2016/11/11
- [Qemu-devel] [PATCH v2 2/5] target-i386: Add Intel HAX files, Vincent Palatin, 2016/11/11
- [Qemu-devel] [PATCH v2 5/5] Plumb the HAXM-based hardware acceleration support, Vincent Palatin, 2016/11/11
- Re: [Qemu-devel] [PATCH v2 0/5] [RFC] Add HAX support, no-reply, 2016/11/12
- Re: [Qemu-devel] [PATCH v2 0/5] [RFC] Add HAX support, Stefan Weil, 2016/11/14
- Re: [Qemu-devel] [PATCH v2 0/5] [RFC] Add HAX support, Stefan Weil, 2016/11/14