[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 12/47] virtio: remove ioeventfd_disabled altogeth
From: |
Christian Borntraeger |
Subject: |
Re: [Qemu-devel] [PULL 12/47] virtio: remove ioeventfd_disabled altogether |
Date: |
Tue, 15 Nov 2016 09:27:08 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 11/10/2016 03:48 PM, Christian Borntraeger wrote:
> On 11/10/2016 03:38 PM, Paolo Bonzini wrote:
>>
>>
>> On 10/11/2016 15:35, Christian Borntraeger wrote:
>>> On 10/30/2016 10:23 PM, Michael S. Tsirkin wrote:
>>>> From: Paolo Bonzini <address@hidden>
>>>>
>>>> Now that there is not anymore a switch from the generic ioeventfd handler
>>>> to the dataplane handler, virtio_bus_set_host_notifier(assign=true) is
>>>> always called with !bus->ioeventfd_started, hence virtio_bus_stop_ioeventfd
>>>> does nothing in this case. Move the invocation to vhost.c, which is the
>>>> only place that needs it.
>>>>
>>>> Reviewed-by: Cornelia Huck <address@hidden>
>>>> Signed-off-by: Paolo Bonzini <address@hidden>
>>>> Reviewed-by: Michael S. Tsirkin <address@hidden>
>>>> Signed-off-by: Michael S. Tsirkin <address@hidden>
>>>> ---
>>>> include/hw/virtio/virtio-bus.h | 6 ------
>>>> hw/virtio/vhost.c | 3 +++
>>>> hw/virtio/virtio-bus.c | 23 ++++++++---------------
>>>> 3 files changed, 11 insertions(+), 21 deletions(-)
>>>
>>> This breaks vhost-net for s390/kvm after rebooting the guest. (ping fails
>>> and
>>> ifconfig shows no packets is TXed)
>>>
>>> Any idea?
>>
>> Patch from Felipe:
>> [PATCH v2] vhost: Update 'ioeventfd_started' with host notifiers
>>
>> Paolo
>
> Yes, that fixes the issue
>
hmm, not quite.
This patch on top of
commit 6bbcb76301a72dc80c8d29af13d40bb9a759c9c6 MAINTAINERS: Remove obsolete
stable branches
still triggers
qemu-system-s390x: hw/s390x/virtio-ccw.c:1076: virtio_ccw_remove_irqfd:
Assertion `ret == 0' failed.
for some cases according to Farhan.
There are too many patches floating around, what is the latest assumed to be
final patch set? We can then test that.
Thanks
Christian