[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v3 26/28] vhost: drop legacy vring layout bits
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PULL v3 26/28] vhost: drop legacy vring layout bits |
Date: |
Wed, 16 Nov 2016 00:00:37 +0200 |
On Tue, Nov 15, 2016 at 09:35:34PM +0100, Greg Kurz wrote:
> On Tue, 15 Nov 2016 21:22:31 +0200
> "Michael S. Tsirkin" <address@hidden> wrote:
>
> > From: Greg Kurz <address@hidden>
> >
> > The legacy vring layout is not used anymore as we use the separate
> > mappings even for legacy devices.
> > This patch simply removes it.
> >
> > This also fixes a bug with virtio 1 devices when the vring descriptor table
> > is mapped at a higher address than the used vring because the following
> > function may return an insanely great value:
> >
> > hwaddr virtio_queue_get_ring_size(VirtIODevice *vdev, int n)
> > {
> > return vdev->vq[n].vring.used - vdev->vq[n].vring.desc +
> > virtio_queue_get_used_size(vdev, n);
> > }
> >
> > and the mapping fails.
> >
>
> Michael,
>
> I see the "vhost: adapt vhost_verify_ring_mappings() to virtio 1 ring layout"
> patch got Cc'ed to stable... any reason for not doing the same with this patch
> since it fixes the bug which motivated the whole series ?
>
> Cheers.
>
> --
> Greg
Not really, I just forgot. Pls go ahead and CC stable.
--
MST
- [Qemu-devel] [PULL v3 18/28] nvdimm acpi: cleanup nvdimm_build_fit, (continued)
- [Qemu-devel] [PULL v3 18/28] nvdimm acpi: cleanup nvdimm_build_fit, Michael S. Tsirkin, 2016/11/15
- [Qemu-devel] [PULL v3 19/28] nvdimm acpi: rename nvdimm_acpi_hotplug, Michael S. Tsirkin, 2016/11/15
- [Qemu-devel] [PULL v3 21/28] nvdimm acpi: fix two comments, Michael S. Tsirkin, 2016/11/15
- [Qemu-devel] [PULL v3 20/28] nvdimm acpi: define DSM return codes, Michael S. Tsirkin, 2016/11/15
- [Qemu-devel] [PULL v3 22/28] nvdimm acpi: rename nvdimm_dsm_reserved_root, Michael S. Tsirkin, 2016/11/15
- [Qemu-devel] [PULL v3 23/28] nvdimm acpi: use aml_name_decl to define named object, Michael S. Tsirkin, 2016/11/15
- [Qemu-devel] [PULL v3 24/28] nvdimm acpi: introduce NVDIMM_DSM_MEMORY_SIZE, Michael S. Tsirkin, 2016/11/15
- [Qemu-devel] [PULL v3 25/28] vhost: adapt vhost_verify_ring_mappings() to virtio 1 ring layout, Michael S. Tsirkin, 2016/11/15
- [Qemu-devel] [PULL v3 26/28] vhost: drop legacy vring layout bits, Michael S. Tsirkin, 2016/11/15
- [Qemu-devel] [PULL v3 27/28] virtio: drop virtio_queue_get_ring_{size, addr}(), Michael S. Tsirkin, 2016/11/15
- [Qemu-devel] [PULL v3 28/28] docs: add PCIe devices placement guidelines, Michael S. Tsirkin, 2016/11/15
- Re: [Qemu-devel] [PULL v3 00/28] virtio, vhost, pc, pci: documentation, fixes and cleanups, Stefan Hajnoczi, 2016/11/15