Re: [Qemu-devel] [PATCH v14 12/22] vfio: Add notifier callback to parent's ops structure of mdev

[Kirti Wankhede]

On 11/17/2016 7:45 AM, Dong Jia Shi wrote:
> * Kirti Wankhede <address@hidden> [2016-11-17 02:16:24 +0530]:
> 
> Hi Kirti,
> 
>> diff --git a/drivers/vfio/mdev/vfio_mdev.c b/drivers/vfio/mdev/vfio_mdev.c
> [...]
> 
>> @@ -51,6 +78,11 @@ static void vfio_mdev_release(void *device_data)
>>      if (likely(parent->ops->release))
>>              parent->ops->release(mdev);
>>
>> +    if (likely(parent->ops->notifier)) {
>> +            if (vfio_unregister_notifier(&mdev->dev, &mdev->nb))
>> +                    pr_err("Failed to unregister notifier for mdev\n");
> For the -ENOTTY case, we should not fail here either.
> 

Removing the error print and ignoring return from this unregister call.
Updating this patch on this thread.

>> +    }
>> +
>>      module_put(THIS_MODULE);
>>  }
>>
> [...]
>