[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tftp: fake support for netascii protocol
|
From: |
Vincent Bernat |
|
Subject: |
Re: [Qemu-devel] [PATCH] tftp: fake support for netascii protocol |
|
Date: |
Thu, 17 Nov 2016 16:58:31 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
❦ 17 novembre 2016 07:27 -0800, address@hidden:
> === OUTPUT BEGIN ===
> Checking PATCH 1/1: tftp: fake support for netascii protocol...
> ERROR: suspect code indent for conditional statements (2, 6)
> #24: FILE: slirp/tftp.c:329:
> + if (strcasecmp(&tp->x.tp_buf[k], "octet") == 0) {
> + k += 6;
>
> ERROR: suspect code indent for conditional statements (2, 6)
> #26: FILE: slirp/tftp.c:331:
> + } else if (strcasecmp(&tp->x.tp_buf[k], "netascii") == 0) {
> + k += 9;
Indentation is consistent with what the remaining of the file.
> ERROR: Missing Signed-off-by: line(s)
Should I resend the patch for that or the amendment I sent in another
mail is sufficient?
--
Vincent Bernat — address@hidden
❬❱ https://www.exoscale.ch