[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] xen_disk: convert discard input to byte ranges
From: |
Olaf Hering |
Subject: |
Re: [Qemu-devel] [PATCH] xen_disk: convert discard input to byte ranges |
Date: |
Fri, 18 Nov 2016 11:30:03 +0100 |
User-agent: |
Mutt/1.6.2 (6759) |
On Fri, Nov 18, Olaf Hering wrote:
> @@ -708,12 +743,10 @@ static int ioreq_runio_qemu_aio(struct ioreq *ioreq)
> + if (!blk_split_discard(ioreq, req->sector_number, req->nr_sectors)) {
> + goto err;
How is error handling supposed to work here?
Initially I forgot the "!", which just hung the mkfs command in domU.
I have not yet tried to force errors in other part of that function.
Olaf
signature.asc
Description: PGP signature
Re: [Qemu-devel] [PATCH] xen_disk: convert discard input to byte ranges, Eric Blake, 2016/11/18