Re: [Qemu-devel] [RFC 05/15] tests: Add rules to non-gtester qtest test cases

[Eduardo Habkost]

On Mon, Nov 21, 2016 at 11:12:03PM -0200, Eduardo Habkost wrote:
[...]
> +define qtest-target =

This breaks on old GNU Make versions. Both patchew and travis-ci reported
similar errors:

  make: *** No rule to make target `check-simpleqtest-x86_64', needed by
  `check-simpleqtest'.  Stop.

Old make versions don't seem to like the "=" operator after "define VAR".
Fixed by:

diff --git a/tests/Makefile.include b/tests/Makefile.include
index 7016737..2799b16 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -808,7 +808,7 @@ SIMPLETEST_OPTIONS = $(if $(V),--verbose,--quiet)
 # $(check-simpleqtest-$(ARCH)-y) automatically includes
 #                                $(check-simpleqtest-generic-y)
 
-define qtest-target =
+define qtest-target
 
 check-simpleqtest-$(1)-y += $$(check-simpleqtest-generic-y)
 

-- 
Eduardo